jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard

Social: Add share status resharing

Open gmjuhasz opened this issue 1 year ago • 2 comments

Fixes https://github.com/Automattic/jetpack-reach/issues/533

Proposed changes:

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

gmjuhasz avatar Aug 30 '24 12:08 gmjuhasz

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/social-share-status-resharing branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/social-share-status-resharing
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Aug 30 '24 12:08 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

github-actions[bot] avatar Aug 30 '24 12:08 github-actions[bot]

Share to 1 connection, skip the other Resharing

This worked fine for me but feel free to test it too

gmjuhasz avatar Sep 02 '24 12:09 gmjuhasz

Yeah, just wrapping up my tests

spsiddarthan avatar Sep 02 '24 12:09 spsiddarthan

A few issues we need to fix here:

  1. When the connection_id is not found in the list, it displays an icon with a tooltip that says, "This connection has been removed." There are a few problems with this:
    • The approach of finding the connection with connection_id for this use-case is problematic because if a connection is reconnected, the connection_id will change, but for the user, it is the sasme social media account and it will confuse them what the connection means here. So, it's better to prefer finding connection by combining service and external_id if present, otherwise, fallback to connection_id for old data.
    • The icon does not have aria-label and it's required for visual only elements.
    • If external_id is not present in the data, we should probably change that tooltip to something like, "This connection has been reconnected or removed."
  2. If a connection has been removed, we still show the retry button and simply return inside onRetry callback, which means that onClick will do nothing in that case. It may be confusing for the user as to why the click doesn't do anything. We should instead disable the button and probably show a tooltip about why it's disabled.
  3. If you click that icon, you will see this error in the console Image

manzoorwanijk avatar Sep 07 '24 07:09 manzoorwanijk

I have created a task for the above issues and added it to our board.

manzoorwanijk avatar Sep 07 '24 08:09 manzoorwanijk