Sean Monahan

Results 74 comments of Sean Monahan

This was released for Fabric 7 in [v7.202.0](https://github.com/microsoft/fluentui/blob/7.0/packages/react/CHANGELOG.md#72020)

This was released for Fabric 7 in [v7.202.0](https://github.com/microsoft/fluentui/blob/7.0/packages/react/CHANGELOG.md#72020)

The issue in the repro case is that `onColumnClick` and `columns` were memoized but did not have all the dependencies listed so they were stale when logged. Updating the dependencies...

This looks like a bug. `text-overflow: ellipsis` is being applied to the text but the container itself is expanding beyond the width of the `ContextualMenu`. ![contextualmenu itemtext devtools](https://user-images.githubusercontent.com/93940821/180301025-35408e5b-16e7-4dce-a9f8-5cf9bf6fbea8.png)

If you can follow the [contributing guide](https://github.com/microsoft/fluentui/wiki/Contributing), code up a fix and file a PR I don't see why you wouldn't be eligible :)

Note: I've put this in the iteration ending on 7/9 but with the holiday it probably won't be complete until the following iteration.

> The classnames are computed every time the hook is called. Would it be possible to wrap the mergeClasses calls in a useMemo? Something like this? #30640 Do you have...

I don't think it's necessary and may actually regress performance. `useMemo()` isn't free and in your example PR the memoization depends on so many values it's likely to be recomputed...

> ```shell > ERROR: there is an invalid dependentChangeType detected @fluentui-react-input-c8edf931-8ef0-4b0b-87e3-eff2133d203c.json: "path" is not a valid dependentChangeType > ``` > > @spmonahan it seems like something wrong with dependentChangeType :...