fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

fix : Input control has dead-zones where clicking does not bring focus to the control

Open vicheanath opened this issue 1 year ago • 5 comments

fix: #30491

Previous Behavior

The mouse pointer is a clue if you are hovering over an area that will bring focus to the input control or not - if it remains an arrow, it won't bring focus; if it switches to the text cursor, then we're actually on top of the underlying input element and clicking will bring focus to the control.

image

New Behavior

Change root from span to label and put :hover

https://github.com/microsoft/fluentui/assets/48352653/64beab66-0f10-4b77-9131-61d55dc88e35

Related Issue(s)

  • Fixes #30491

vicheanath avatar Feb 09 '24 04:02 vicheanath

@microsoft-github-policy-service agree

vicheanath avatar Feb 09 '24 04:02 vicheanath

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 09 '24 04:02 codesandbox-ci[bot]

ERROR: there is an invalid dependentChangeType detected @fluentui-react-input-c8edf931-8ef0-4b0b-87e3-eff2133d203c.json: "path" is not a valid dependentChangeType

@spmonahan it seems like something wrong with dependentChangeType : "path", I'm not sure but it fails this path

vicheanath avatar Feb 13 '24 19:02 vicheanath

ERROR: there is an invalid dependentChangeType detected @fluentui-react-input-c8edf931-8ef0-4b0b-87e3-eff2133d203c.json: "path" is not a valid dependentChangeType

@spmonahan it seems like something wrong with dependentChangeType : "path", I'm not sure but it fails this path

Sorry! I looked and saw I told you to do the wrong thing. It should be patch with a "c" :)

spmonahan avatar Feb 13 '24 19:02 spmonahan

that's fine I will fix it thanks.

vicheanath avatar Feb 13 '24 20:02 vicheanath

Hi @vicheanath, are you still working on this PR? If not, I'll make the changes I suggested in my review. Thanks!

behowell avatar Mar 14 '24 18:03 behowell

Hi @vicheanath, are you still working on this PR? If not, I'll make the changes I suggested in my review. Thanks!

I've created PR https://github.com/microsoft/fluentui/pull/30825 to implement the suggestions from my review.

behowell avatar Mar 19 '24 20:03 behowell

This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI!