Sean Monahan

Results 74 comments of Sean Monahan

@tonyhallett The issue with API extractor is that you need to commit an updated API snapshot. You can build the snapshot with ``` yarn lage @fluentui/react build ``` Then just...

> This was before I pulled master so perhaps the logic has changed Ah, you might need to regenerate the API snapshot then. Probably there are other API changes that...

@tonyhallett Let's go ahead with these alignment changes.

> @spmonahan This pr now addresses #24837 > > I think that the code is ok but will compare the examples by eye tomorrow. Sounds good! Before you do that...

I believe this is due to how row and page heights are calculated for virtualization. These Github issues appear to be related: - #20037 - #20978

Thanks for adding those details @sirdawidd. I've spent some more time recently looking at this and while I don't yet have a fix I believe I now know the root...

Hello! I've recently merged #24460 which introduces a new version of `GroupedList` called `GroupedListV2`. V2 is an API-compatible reimplementation of `GroupedList` (`GroupedList` being the control that provides nesting for `DetailsList`)....

Possibly related issue in Beachball repo: https://github.com/microsoft/beachball/issues/583

Related issue: https://github.com/marwan38/fluentui/commit/ada38f440b819f53d19a3bf96bb8ed3e99be3b81

@emilyamclean Looks like the chevron color tokens are already correct, just _very_ subtle. https://user-images.githubusercontent.com/93940821/196556750-5165ec37-dcff-457b-826d-c027f0fad579.mp4