fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

feat: add ".js" extension to all imports

Open spmonahan opened this issue 1 year ago • 3 comments

Previous Behavior

None of the imports in @fluentui/tokens had .js extensions.

New Behavior

All of the imports in @fluentui/tokens have .js extensions (well, except for type imports but these are erased from the shipped artifacts so it doesn't make sense to add them).

This changes allows @fluentui/tokens' ESM output to be correctly loaded in a browser.

Related Issue(s)

  • #23508

spmonahan avatar Feb 20 '24 19:02 spmonahan

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam avatar Feb 20 '24 19:02 fabricteam

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 20 '24 19:02 codesandbox-ci[bot]

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
328 B
global-context
createContextSelector
537 B
339 B
react-accordion
Accordion (including children components)
100.12 kB
30.422 kB
react-alert
Alert
83.737 kB
23.474 kB
react-avatar
Avatar
50.175 kB
15.944 kB
react-avatar
AvatarGroup
19.704 kB
7.796 kB
react-avatar
AvatarGroupItem
64.831 kB
20.274 kB
react-badge
Badge
26.905 kB
8.729 kB
react-badge
CounterBadge
27.806 kB
9.024 kB
react-badge
PresenceBadge
25.311 kB
9.306 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
115.465 kB
31.832 kB
react-button
Button
39.513 kB
11.169 kB
react-button
CompoundButton
46.874 kB
12.661 kB
react-button
MenuButton
44.292 kB
12.542 kB
react-button
SplitButton
52.306 kB
14.134 kB
react-button
ToggleButton
56.559 kB
13.068 kB
react-calendar-compat
Calendar Compat
152.067 kB
39.826 kB
react-card
Card - All
101.55 kB
28.92 kB
react-card
Card
96.373 kB
27.403 kB
react-card
CardFooter
13.064 kB
5.385 kB
react-card
CardHeader
15.307 kB
6.143 kB
react-card
CardPreview
14.015 kB
5.752 kB
react-checkbox
Checkbox
35.65 kB
12.076 kB
react-combobox
Combobox (including child components)
102.176 kB
32.976 kB
react-combobox
Dropdown (including child components)
103.543 kB
32.927 kB
react-datepicker-compat
DatePicker Compat
224.513 kB
62.955 kB
react-dialog
Dialog (including children components)
100.923 kB
29.928 kB
react-divider
Divider
20.82 kB
7.763 kB
react-field
Field
22.544 kB
8.61 kB
react-image
Image
15.745 kB
6.23 kB
react-infobutton
InfoButton
138.69 kB
43.394 kB
react-infobutton
InfoLabel
142.491 kB
44.625 kB
react-input
Input
26.887 kB
9.118 kB
react-jsx-runtime
Classic Pragma
1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime
3.783 kB
1.648 kB
react-jsx-runtime
JSX Runtime
4.377 kB
1.881 kB
react-label
Label
14.266 kB
5.828 kB
react-link
Link
17.082 kB
6.911 kB
react-menu
Menu (including children components)
149.422 kB
45.506 kB
react-menu
Menu (including selectable components)
152.108 kB
46.016 kB
react-message-bar
MessageBar (all components)
25.566 kB
9.131 kB
react-overflow
hooks only
12.862 kB
4.827 kB
react-persona
Persona
57.066 kB
17.821 kB
react-popover
Popover
126.88 kB
39.806 kB
react-portal
Portal
13.629 kB
4.875 kB
react-positioning
usePositioning
26.398 kB
9.539 kB
react-progress
ProgressBar
17.428 kB
6.898 kB
react-provider
FluentProvider
23.751 kB
8.66 kB
react-radio
Radio
32.946 kB
10.252 kB
react-radio
RadioGroup
15.354 kB
6.265 kB
react-select
Select
28.609 kB
10.205 kB
react-slider
Slider
39.943 kB
12.969 kB
react-spinbutton
SpinButton
36.774 kB
11.788 kB
react-spinner
Spinner
23.517 kB
8.512 kB
react-switch
Switch
35.134 kB
11.198 kB
react-tags
InteractionTag
15.259 kB
6.058 kB
react-tags
Tag
29.982 kB
9.439 kB
react-tags
TagGroup
80.55 kB
24.027 kB
react-text
Text - Default
16.705 kB
6.569 kB
react-text
Text - Wrappers
19.878 kB
6.896 kB
react-textarea
Textarea
30.947 kB
10.476 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.616 kB
7.317 kB
react-theme
Teams: Light theme
19.287 kB
5.498 kB
react-timepicker-compat
TimePicker
104.206 kB
34.375 kB
react-toast
Toast (including Toaster)
100.192 kB
29.763 kB
react-tooltip
Tooltip
54.576 kB
19.192 kB
react-utilities
SSRProvider
180 B
160 B
🤖 This report was generated against a0bb58f2ac1d9f50bce33b7a9c4fb6b09922a956

fabricteam avatar Feb 20 '24 19:02 fabricteam

See #30582

spmonahan avatar Feb 22 '24 17:02 spmonahan