Martin Spier

Results 68 comments of Martin Spier

Different thing, but it could be addressed by a custom `value` function. Idea is to have a flame graph based on data.delta values, not data.value.

> > Currently, value would be the same > > No, value is computed by `node.sum()` and will change by zooming. When zooming, yes, but that was the intended effect....

The delta. It's a different kind of visualization.

> I think `node.value` must have no relation to item's value, other than it should establish desired proportions of nodes in chart. Then it'll be easier to implement log scales...

This can be achieved today with a custom `getValue` function. Delta only flame graph would be something like: ``` .getValue((d) => d.data.delta) ``` You could also change the `value` in...

> What is the use case for `node.value` other than node's width? Exactly when I need to know the node's width.

@wonder-mice prefer to treat those changes as a separate PR?

> Don't accept any PR from me for now. I need to rework the patch set, found other issues. Ok, I'll wait for the new PR. FYI, I'll be traveling...

Sure @rohchakr. Should be a simple feature. Today, search is done via RegEx and is case sensitive. Having an option to ignore case on search would be beneficial. With the...

It could be just a library option. No need to update the examples, just document it on the README.