Martin Spier
Martin Spier
@wonder-mice that's the large one. Might need a bit more time to review. After this, it's just a simple function rename PR that should be merged straight away.
Without looking into the code too much yet, with my not-so-large example profiles, this can be 2x faster than current `master`. Having said that, it's a very different approach to...
> I realized my mistake. Looks like your intention was to be a d3 plugin. But I was looking at it as flamegraph builder that just happened to use d3...
Need to move `chartRightBoundary` to tooltip to maintain `.show` compatibility with d3-tip.
> @spiermar I was wondering about the reason why we want our `.show` to be compatible with d3-tip. d3-tip.js seems to be a standard and we would want users to...
Check if there's a function to push/merge/join `d3.hierarchy` structures directly, without having to merge raw data.
See https://github.com/d3/d3-hierarchy/issues/139
Not that I'm aware of, but open to suggestions.
> Looks like found a "bug" - `getChildren` is used both with d3 nodes and with data nodes. > > I suggest to name d3 nodes "nodes", since they are...
> When clicking on node to zoom in, this changes value in tooltip for all nodes on the path to clicked node: > http://martinspier.io/d3-flame-graph/ > > I think tooltip label...