d3-flame-graph icon indicating copy to clipboard operation
d3-flame-graph copied to clipboard

delta only option for differential flame graphs

Open spiermar opened this issue 5 years ago • 7 comments

spiermar avatar Sep 19 '18 22:09 spiermar

I'm not sure what the plan is here, but will not it be addressed by allowing custom getDelta/getValue callbacks?

wonder-mice avatar Sep 29 '18 19:09 wonder-mice

Different thing, but it could be addressed by a custom value function. Idea is to have a flame graph based on data.delta values, not data.value.

spiermar avatar Sep 29 '18 22:09 spiermar

What will be the width of a node in this case?

wonder-mice avatar Sep 29 '18 23:09 wonder-mice

The delta. It's a different kind of visualization.

spiermar avatar Sep 30 '18 00:09 spiermar

Hi @spiermar Since it has been a while, may I get an update on this?

Do we have any alternative option today to display a differential flamegraph?

shawncao avatar Aug 17 '20 22:08 shawncao

This can be achieved today with a custom getValue function. Delta only flame graph would be something like:

.getValue((d) => d.data.delta)

You could also change the value in the data structure too. It would achieve the same result.

I'm not using delta only in any tools today. Found that differential with red blue frame shades + elided flame graphs, side by side, work best for finding differences.

spiermar avatar Aug 17 '20 22:08 spiermar

Sounds good, thank you for your quick reply!

shawncao avatar Aug 17 '20 22:08 shawncao