Solar Designer

> all above crashes in existing formats were fixed in #5047. If so, I think there's no reason to treat the remaining aspects of this issue as a priority, so...

On Sat, Sep 02, 2017 at 09:35:38AM +0000, magnum wrote: > There's also (iirc) the possibility to generate 512 bits, try ciphers, then **continue** generating bits so we get 1024...

I did miss the comment edit. The speedup you mention is compared to the case of first computing 512 bits and then computing 1024 bits from scratch, which is obviously...

We have many instances of these in mask-aware formats: ``` #if SIZEOF_SIZE_T > 4 /* We can't process more than 4G keys per crypt() */ while (gws_limit * mask_int_cand.num_int_cand >...

Oh, that `BENCH_CLERROR` is indeed problematic - not because of `crypt_all` return value type, but because our current calls to `crypt_all` don't expect a `-1` return. We need to either...

This issue might be partially? fixed by 47008003c1b0494cfbe183b60649e068e51c4b59 - need to review/re-test.

I guess a similar problem would be seen if the first rule is (almost) skipped for any other reason - e.g., if it rejects most words quickly, then the second...

We should also look into how `--show` works on PWDUMP and other `prepare()`-using formats, and how we'd like it to work after any change we might make here.

@isieditors Can that hash you obtained be cracked with `john`?

@isieditors Well, it looks like this is a new wallet type we need to add support for. Is this a dummy test wallet that you can share? If so, please...