Solar Designer

Results 703 comments of Solar Designer

@JamieSlome @huntr-helper Incidentally, the huntr platform doesn't appear to let a maintainer approve the bug report, but decline security relevance. There is a way to specify that user interaction is...

I guess fixing this issue will affect restored sessions, which may then skip some rules even if the input rule set has not changed. I don't know if we want...

> my `-ru=jumbo` [...] doesn't contain that rule. It has changed since - to reproduce with the exact rule in my original comment, you need `john.conf` from back then. >...

Also, only dropping before preprocessor is a reasonable mode - even if far less effective than what we could have. If that's the only issue here, then maybe we shouldn't...

BTW, my switching us to pre-optimized and thus pre-expanded default rules, with extra effective NOP squeezing with `sed` (as documented in the comments), lowers priority of us implementing any enhancements...

If this issue is not only the pre- vs. post-pp aspect, and we fix it, and `OneRuleToRuleThemAll` is literally a subset of `hashcat` (someone should check this - I did...

> That suggests the suppression is happening after PP Does it suggest that? I think it does not: the hashcat-derived rule sets are large, and don't use PP.

> That pp line is indeed a dupe line in the config Oh, probably a config file bug for us to fix, then? We could drop the dupe line, or...

BTW, an issue we probably did not consider: same-looking line could be a different rule in native vs. hashcat mode because some rule command characters overlap and have different semantics....

> The dupe config line was added in [0402542](https://github.com/openwall/john/commit/0402542a92a9b1daefd9267bdab598cd3cbb0b06) after you posted [#3789 (comment)](https://github.com/openwall/john/issues/3789#issue-431997416) with the dupe present. Looks like I arrived at this same rule in two different ways....