Solar Designer

@marksilinio magnum is correct, our preferred is the same one you had used in `apop2john.py` - can you do the same here? GPLv2 is also fine if you insist, just...

Do we want to merge this script now or only along with the corresponding JtR format? We similarly had a PR with `bestcryptve2john.py` hanging around for months and only merged...

> I'll write the formats soon so let's wait a little. OK. > I might even be able to push the formats commits to this same PR I think it's...

> variable length array I think we did not intend to depend on that functionality anywhere in this tree. So it's a portability bug.

Looks like an actual bug to me, not just a warning. glibc has workarounds for things like that, but some other libc's might not, and for chars with 8th bit...

Not all gcc 10 give these warnings - IIRC, my build of gcc 10.2.0 on "super" does not produce any warnings when building jumbo.

> Perhaps it's more about build options? Could be. @AlekseyCherepanov Did you use any options when you got these warnings? IIRC, we first saw the warnings about `$$F` for some...

Some of the above also applies to the SSH formats (CPU and OpenCL), which have similar padding and ASN.1 checks.

> in `pem_common_plug.c: pem_decrypt()` we could also drop the initial `memset` (looks unnecessary?) Confirmed by changing `0` to `-1` - it still passes self-tests.

This is not pretty, seen while running `--test-full=1`: ``` Testing: PEM, PKCS#8 private key (RSA/DSA/ECDSA) [PBKDF2-SHA1 32/64 3DES/AES]... (3xOMP) Warning: PEM kdf algorithm is not supported currently! PASS ```