Sebastian Noack

Results 18 comments of Sebastian Noack

I recently worked on a project using Rollup, and had a chance to use [`rollup-plugin-visualizer`](https://github.com/btd/rollup-plugin-visualizer). It looks very similar to `webpack-bundle-analyzer` but with one minor addition that was incredibly useful...

Thanks, very much appreciated! But reviewing this huge PR is difficult. Let's land #21 separately, and if you don't mind can you move the other changes that are unrelated of...

I didn't do a full review yet (as this pull request is difficult to review until rebased/merged against `master`) but I already have a couple remarks: 1. I'm not a...

This merge request seems incomplete. It doesn't add Python 3.8 to `tox.ini`and `.travis.yml`, and the changes break on other Python versions (see the CI status).

@judy2k, what is your stance on that? I mostly decided to use the Unlicense for this module since it's the same license used by [stupid-python-tricks](https://github.com/judy2k/stupid-python-tricks) and [ish](https://github.com/judy2k/ish) which inspired me...

Can you rebase this pull request? (Or alternatively merging `master` back into your branch does as well.)

So you are suggesting to merge #22 before merging this PR? Fine with me, just rebase (or merge) #22 against the current `master`, and I have a look.

That the order of ingredients can effect the search result is just the natural behavior of the relevance ranking algorithms used by virtually every full text search engine, i.e. Sphinx...

Updated the branch, this hopefully fixes the issues on the CI.