python-goto icon indicating copy to clipboard operation
python-goto copied to clipboard

Published 20 hours ago • verified publisher icon snoack

Adds Python3.8 support

Open insignification opened this issue 5 years ago • 5 comments

Based on PR #21, adds python3.8 support (previously part of the 'fix2' PR)

insignification avatar Dec 14 '19 00:12 insignification

Details:

  1. Python 3.8 adds another parameter to CodeType constructor, but also luckily adds a replace method to make code construction more version-independent.
  2. Python 3.8 removes SETUP_LOOP, so in this situation, we rely on FOR_ITER and POP_TOP instead.

insignification avatar Dec 14 '19 00:12 insignification

Can you rebase this pull request? (Or alternatively merging master back into your branch does as well.)

snoack avatar Dec 15 '19 06:12 snoack

FYI the "Various minor crash/etc fixes" one doesn't fail checks, probably best to skip this PR and merge that. (No point in trying to analyze an already fixed bug)

insignification avatar Dec 15 '19 11:12 insignification

So you are suggesting to merge #22 before merging this PR? Fine with me, just rebase (or merge) #22 against the current master, and I have a look.

snoack avatar Dec 15 '19 11:12 snoack

Yes, let's focus on #22 instead of this PR. It's provided here so you can review it as a "step" separate from #22, but it's evidently missing some fixes included in #22 and there's no reason to start digging which fix is needed.

(And I don't see a reason to remove the py38 changes from the #22 PR before merging it, you've already reviewed them here, it'd just be extra busywork)

It's already merged against master, and I'll fix it up per your comments and flake8 shortly

insignification avatar Dec 15 '19 19:12 insignification