core icon indicating copy to clipboard operation
core copied to clipboard

Add entities for Balboa Spa pumps

Open snoack opened this issue 1 year ago • 3 comments

Proposed change

The Balboa Spa integration was missing entities to control the pumps (for the jets) of the Hot Tub. This PR is adding entities for the pumps. As requested this was split out of #111222 to limit the scope.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • ~~This PR fixes or closes issue: fixes #~~
  • ~~This PR is related to issue:~~
  • Link to documentation pull request: home-assistant/home-assistant.io#31587

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
    • (Do I need to bother running tests locally, or will they run when I submit this PR automatically?)
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

snoack avatar Feb 23 '24 23:02 snoack

Hey there @garbled1, @natekspencer, mind taking a look at this pull request as it has been labeled with an integration (balboa) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of balboa can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign balboa Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 23 '24 23:02 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 24 '24 19:02 home-assistant[bot]

Updated the branch, this hopefully fixes the issues on the CI.

snoack avatar Feb 24 '24 20:02 snoack

Does it matter that there are no existing tests for this component?

snoack avatar Feb 26 '24 21:02 snoack

Well, the integration has a nearly 100% test coverage which we would break without a test. So I would encourage you to add one.

jpbede avatar Feb 26 '24 21:02 jpbede

You are right, I didn't find the tests initially.

snoack avatar Feb 26 '24 21:02 snoack

I had a go but not sure if the test works. I couldn't get the tests to run locally. I keep getting AttributeError: module 'homeassistant.components' has no attribute 'zeroconf' when running tests for this component (even without my changes here)?

snoack avatar Feb 28 '24 01:02 snoack

I hope you don't mind me fixing the test for you, that would have been too much for comments I think. So feel free to have a look and apply it to your other PR when this one is merged 🙂 .

jpbede avatar Feb 28 '24 11:02 jpbede