Šarūnas Nejus
Šarūnas Nejus
> > Meanwhile, there is a record in the database that matches them exactly. > > Unfortunately it is not really exact, because of the extra word "volume". > >...
Same, on my end it writes `mb_artistid`, `mb_albumartistid` and (less often) `albumtypes`
This looks good. Since this PR does not change the interface to the world, I think, it doesn't require a major version bump. We'd rather save it for the future...
> I'm not sure the gitblame is able to pickup the moved files but I can add it. You need to supply `-CM` flags to `git blame` to take into...
> Imports changed all over the place Internally, they have. However, from the perspective of an upstream consumer, they seem to still be available in `mediafile.py`. On the other hand,...
It seems like commits cbc64e3 and 0c6ccd4 should be moved to #87, right? Presumably, the scope of this PR is restructuring of everything under `mediafile` folder.
> That's the reason why I want to do a proper 1.0.0 release to properly define the public api. See [here](https://github.com/beetbox/mediafile/pull/86#issuecomment-3446871917). I dont think we need to care about this...
It indeed doesn't break! I guess, `confuse` broke because it had ```py # confuse/__init__.py from core import * ``` And the star import picked up only the members defined in...
> It was like this [before](https://github.com/beetbox/mediafile/blob/83157ca0f6643bab50e46f8d5378d062ae85fb39/mediafile.py#L60). Thought it might be useful to have the types exported too so I added them. I didn't realise this! This probably got lost in...
Have just rebased it - keen for this to be merged!