Šarūnas Nejus

Results 229 comments of Šarūnas Nejus

Regarding the casting issue, we've got a plugin `types` which is supposed to handle types for flexible attributes. I do not think that it supports multi value/list field type yet,...

I tend to keep project / dependencies specification separately from linters configuration. This way, seeing a change in `pyproject.toml` my brain instantly associates it with an update to the dependencies...

Not sure if you've seen my review comment > Would it be possible to isolate method moves into a separate commit? It's a bit complicated to see the relevant changes...

> ### [`allow_redefinition = true`](https://mypy.readthedocs.io/en/stable/config_file.html#confval-allow_redefinition) > > * **Why**: This allows reassigning or shadowing a name with a different type within a function or scope. It’s helpful for code clarity,...

To start with, we could potentially document this somewhere in the **Windows** / **Installation** docs?

Apologies, did not see your comment until now @lets-order-some-fries. Assigned it to you now!

The build on `win32` is failing to install `reflink` because it's [only supported until Python 3.7](https://gitlab.com/rubdos/pyreflink/-/blob/master/setup.py?ref_type=heads). I will address this in a separate PR and rebase this one accordingly once...

> Hey, LRCLIB author here 👋. It would be great if you could make the `/search` API a fallback for the `/get` API (instead of replacing it entirely) when no...

Snap, I wish I'd seen your PR earlier! It does, however I'm not sure when will it get reviewed and merged in, so let's get your PR merged in first!...

> Okay, sounds like a plan to me! > > This is probably more suitable for your other PR (#5474), but I'll mention this here. In the comments of my...