puppet-mongodb icon indicating copy to clipboard operation
puppet-mongodb copied to clipboard

Fix: User isn't removed from non-admin database

Open SeanHood opened this issue 3 years ago • 4 comments

Pull Request (PR) description

Currently setting ensure => absent for a user doesn't work for users created in other databases than admin

This Pull Request (PR) fixes the following issues

This PR fixes this by passing the database value to mongo_eval

SeanHood avatar Jul 07 '22 16:07 SeanHood

I have a feeling, this patch needs to be applied to get tests running. Should this be in this PR or a separate one?

diff --git a/.fixtures.yml b/.fixtures.yml
index 9937c6d..97dc093 100644
--- a/.fixtures.yml
+++ b/.fixtures.yml
@@ -1,7 +1,7 @@
 fixtures:
   repositories:
-    "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
-    "apt": "git://github.com/puppetlabs/puppetlabs-apt.git"
+    "stdlib": "https://github.com/puppetlabs/puppetlabs-stdlib.git"
+    "apt": "https://github.com/puppetlabs/puppetlabs-apt.git"
     "systemd": "https://github.com/voxpupuli/puppet-systemd.git"
     "zypprepo": "https://github.com/voxpupuli/puppet-zypprepo.git"
     yumrepo_core:

SeanHood avatar Jul 07 '22 16:07 SeanHood

I just merged #643 which include it. Let's re-trigger a build

smortex avatar Jul 08 '22 19:07 smortex

Hum, one day I will understand what GitHub does with the repo before running CI. I though it would merge the branch and the main branch but it seems not to…

Can you please rebase your changes on top of the main branch?

From your working directory:

git fetch origin       # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)

Thanks!

smortex avatar Jul 08 '22 19:07 smortex

Different failures, I'll take a look at those now.

SeanHood avatar Jul 08 '22 19:07 SeanHood