djangobench icon indicating copy to clipboard operation
djangobench copied to clipboard

form validation benchmark added

Open deepakdinesh1123 opened this issue 2 years ago • 3 comments

deepakdinesh1123 avatar May 02 '22 10:05 deepakdinesh1123

Hey @deepakdinesh1123

Thank you for the contributions here.

Maybe we should be adding these to the ASV repo as the primary way we wish for benchmarks to be run going forward? If we think ASV is useful, then we'll end up writing, and reviewing the benchmarks twice.

What do you think?

smithdc1 avatar May 03 '22 21:05 smithdc1

I had thought of adding the benchmarks to this repo and getting them reviewed and then migrating all of them after making changes to the directory structure of the ASV repo but adding these benchmarks to the ASV repo sounds much better as I wouldn't have to write them twice. I was able to add the benchmark along with the existing benchmarks, I will add them to the ASV repo.

deepakdinesh1123 avatar May 04 '22 13:05 deepakdinesh1123

I wouldn't have to write them twice.

Super :-)

smithdc1 avatar May 05 '22 18:05 smithdc1