Scott Minster

Results 11 comments of Scott Minster

Before this PR can be merged, the branch needs to be updated to add the two new WGS84 files to the `Makefile`.

Some initial thoughts: * Several of the changes reference "conda". I'm not sure that depending on Anaconda (or miniconda) for this library is appropriate. * The changes (and the PR...

This biggest issue that I have with this change is that it is a lot of code, but the interfaces are almost exactly the same as what we currently have,...

Before this PR can be merged, the new files must be added to the `Makefile`.

there is some oddities with the Makefile.win32 file. You cannot even use the all target there to get the library out. I'm not sure why exactly.

Using CMake would probably be better than my basic Makefiles :) When building on Windows, do you use the `objects_to_def` script?

Oops, I thought it was under the `scripts` directory, but it looks like it isn't. I'll have to look into adding it there.

@jessemapel I created PR #11 to deliver those scripts to the `scripts` directory

I don't think it's a good idea to add PDF files to this repository like that. Adding binary files just bloats the repository, making it slower to clone. Please remove...

I tried compiling these changes and got compile errors. Of course, that was after I updated the `Makefile` to include the new files. So first, you need to modify the...