csm icon indicating copy to clipboard operation
csm copied to clipboard

Usgs Astro CSM Code Changes

Open acpaquette opened this issue 1 year ago • 3 comments

Hello,

Here are some changes from the USGS astro fork of the CSM. Most of these changes were made for CSM 3.0.3 but may be portable into the current version. The most notable are the CMake files and potentially the CI for appveyor and travis.

I just made the PR into the master area but I can update the PR as needed.

Adam Paquette

acpaquette avatar Jan 08 '24 22:01 acpaquette

Some initial thoughts:

  • Several of the changes reference "conda". I'm not sure that depending on Anaconda (or miniconda) for this library is appropriate.
  • The changes (and the PR title) refer to 3.0.3. The latest version of CSM is 3.1.0. This PR needs to be updated for those latest changes.
  • The changes in Ellipsoid.h just seem to be whitespace changes. They should probably be removed.
  • I don't like how Ellipsoid.cpp was changed to have Windows line endings (CRLF). All the other files have UNIX line endings (LF). The changes other than the whitespace changes in that file remove changes that were previously done that I don't think we want undone.

I'll probably have other comments, these are just my initial thoughts.

sminster avatar Jan 09 '24 17:01 sminster

Sweet, thank you for the initial review @sminster. We initially used 3.0.3.3 to create the USGSCSM set of camera so I wasn't sure if we would want the updates in 3.0.3 or main. I can rebase onto main and make some of the changes you have suggested

acpaquette avatar Jan 09 '24 17:01 acpaquette

@sminster I think I addressed most of your initial thoughts, and this PR should be ready for a review

acpaquette avatar Jan 31 '24 16:01 acpaquette