csm icon indicating copy to clipboard operation
csm copied to clipboard

Add seven new files for Multi-point capabilities. GAS/3.0.4

Open roseej opened this issue 3 years ago • 4 comments

roseej avatar Jan 10 '22 12:01 roseej

remove documents per NGA guidance

roseej avatar Jan 10 '22 12:01 roseej

I don't think it's a good idea to add PDF files to this repository like that. Adding binary files just bloats the repository, making it slower to clone. Please remove them from this PR and do not do that in the future.

sminster avatar Jan 10 '22 20:01 sminster

I tried compiling these changes and got compile errors. Of course, that was after I updated the Makefile to include the new files. So first, you need to modify the Makefile to include the files. Then you need to fix the compile errors, mostly in csmMultiPoint.h. I think they are a result of using C++11 features. We could make that a required standard, but that would mean adding something like -std=c++11 to the COPTS in the various Linux makefiles at least.

Also, I think you should do a git rm on the two PDFs. That won't really remove them from the Git history, but I don't think we want those two in what people see all the time.

sminster avatar Sep 15 '22 15:09 sminster

Before this PR can be merged, the new files must be added to the Makefile

sminster avatar Aug 07 '23 16:08 sminster