Chris Smiet

Results 6 comments of Chris Smiet

I see that the test are passing, could this fix be merged soon? With the numpy 2.0.0 update the diverged branch of @zhucaoxiang is no longer compiling, and maintaining it...

I am glad to help! I cannot see the conflicts myself, I pulled jameskermode:master into my branch of zhucaoxiang:main_off and there were no merge confilcts. Am I missing something? I...

There you go, ready to merge I believe! I see that #220 addresses numpy2.0 support better than what I had done.

Could you restart the tests now that #220 has been merged? This should hopefully fix it (on our branch I had the same error before I switched to numpy2.0). If...

Sorry, Caoxiang ran black over the source and it is really hard to disentangle the logic changes from all the syntax changes. I found a change I missed and have...

We apologize for the syntax changes. Unfortunately, isolating them isn't feasible as the initial commit contains substantial amounts of logic changes. @zhucaoxiang and I explored solutions together but found no...