Chris Smiet

Results 65 comments of Chris Smiet

Does anyone know why the unit tests are failing? The code I submitted does not affect the tests that fail...

@andrewgiuliani I intended this method to provide different functionality from the example; the dofs are not shared, but a full copy is made. This would allow the user also for...

@mbkumar this is the way, and this is why we have code review. I will implement the change, update the pull request and re-factor the code I have written using...

All latest version `0.19.0`: in container ``` (spec_simsopt) smiet@cl-cours@spcpc629:~> docker run --rm -it hiddensymmetries/simsopt root@3555c79e168c:/# python -c"import simsopt; print(simsopt.__version__)" 0.19.0.post90+g490282b3 ``` on my own system: ``` (spec_simsopt) smiet@cl-cours@spcpc629:~> python -c"import...

Tried it, same happens when calling the tests from the simsopt repo on host system that is mounted into the docker: [testoutput.log](https://github.com/hiddenSymmetries/simsopt/files/13218814/testoutput.log) When I uncomment the crashing test, unittests show...

I cannot find the cause but I can reproduce. The tests that fail are: ```python ====================================================================== ERROR: test_iotas_derivative (geo.test_surface_objectives.IotasTests) (label='Volume') Taylor test for derivative of surface rotational transform wrt coil...

Hi @landreman, @florianwechsung, I would love to get on this (part-time), I rely on the docstrings of functions a lot! Won't be an overnight thing, but I am planning on...

Thank you for raising your first issue! I tried reproducing your error, but on my desktop everything runs correctly. With an Instruction Error I can only think it has something...

I have been able to reproduce the error on my laptop which also has an i7. This might indicate that it is an issue with the architecture. I do not...