Chris Smiet
Chris Smiet
@zhucaoxiang I completely agree with using the object-oriented style, and with using keyworded arguments as much as possible! I think that putting all the functions into the base class can...
I agree with @landreman and @andrewgiuliani, BMW will interpolate between the last phi plane and the first (flipped and copied according to the relevant symmetry), and the equivalently functioning `InterpolatedField`...
Now thinking we might want to temporarily force numpy
Update: f90wrap needs to be adapted as well to make spec (and simsopt) run with numpy 2.0. Working with the upstream to merge a [pull-request](https://github.com/jameskermode/f90wrap/pull/194 ). In the meantime we...
nptyping does not seem to have any compatibility with numpy2.0, and when installed under 2.0 raises an exception upon import. Currently it's dependency is set to numpy
Tests are failing because of a few deprecated numpy uses. See the branch [ml/vmec_update_for_numpy_2](https://github.com/hiddenSymmetries/simsopt/tree/ml/vmec_update_for_numpy_2) and it's tests for progress. @florianwechsung the `randomgen` package is not updated for numpy 2.0, could...
@mbkumar You need to use the main_off branch, this is up-to-date with remote, works with numpy2.0 and has an open pull request. For now this branch is needed for the...
Sorry @mbkumar, the new branch also needs (for the time being) the `numpy2_fix` branch of SPEC. The [PR](https://github.com/PrincetonUniversity/SPEC/pull/199) is awaiting review. See the changes I made the `ml/vmec_update_for_numpy_2 workflows` ```...
@mbkumar You are a contributor to SPEC, If you give [the PR](https://github.com/hiddenSymmetries/simsopt/issues/427#issuecomment-2189278030) a quick glance and agree with the changes, you can approve and merge.
@mbkumar The new version of SPEC is merged into master