Sam Lantinga
Sam Lantinga
If you write the function, I can thread it.
> * Review the need for a new subsystem? (Possibly integrate it to the Video subsystem) We don't need a new subsystem for this. > * Move the function that...
> @slouken Is there an SDL equivalent to `snwprintf` for wide-char strings? Yep: SDL_swprintf()
> Note for reviewers: I replaced the SDL_TrayEntryFlags enum with an Uint32 and #defines to make them OR'able without warnings. I basically copied what I saw for SDL_InitFlags, but I'm...
Yep, this looks good. Thanks for the iteration!
> API-wise, would it be good to replace SDL_InsertTraySeparatorAt with SDL_InsertTrayEntryAt + a flag to indicate that a separator is wanted? > > What prompts the question is the current...
> > Is it reasonable for a tray entry to be defined as a separator if it's name is NULL? > > Reminds me I forgot to add a getter...
> About entries with a checkbox, I noticed that platforms by default won't change the value of the checkbox when the user presses on it, and it's the job of...
> Should I keep track of creating flags, and should I forbid manual checking/unchecking of entries not created as checkboxes? Sure, we can remove that limitation later if it ends...
> @slouken Is it okay for test programs to depend on systems other than the one they're testing? I'm remaking testtray.c and I thought about doing a dynamically editable tray...