Sebastien Loriot

Results 671 comments of Sebastien Loriot

@lrineau your review is still needed

Since the target is from CGAL, shouldn't be prefixed with CGAL? Or even CGAL_OpenMesh_support to be consistent?

Successfully tested in CGAL-6.0-Ic-300

Successfully tested in CGAL-6.0-Ic-321

@zs0510 could you please try https://github.com/CGAL/cgal/pull/8418 and let us know if it fixes the issue you are having?

Could this be assigned to @SaillantNicolas ?

`Cannot open include file: 'CXGAL/IO/OM.h'`

``` /mnt/testsuite/test/Lab_Demo/Plugins/IO/OM_io_plugin.cpp:208:10: fatal error: om_io_plugin.moc: No such file or directory 208 | #include "om_io_plugin.moc" ``` I guess you are missing something in the cmake list of the plugin

``` /mnt/testsuite/test/Lab_Demo/Plugins/IO/OM_io_plugin.cpp:208:10: fatal error: om_io_plugin.moc: No such file or directory 208 | #include "om_io_plugin.moc" ``` in https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0.1-Ic-342/Lab_Demo/TestReport_lrineau_Debian-Testing.gz

ICE on MSVC 2022. See [here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0.1-Ic-345/BGL_OpenMesh_Examples/TestReport_Christo_MSVC-2022-Community-Release.gz)