cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

Add CGAL::IO::read_OM()

Open afabri opened this issue 1 year ago • 8 comments

Summary of Changes

Add a function to read an OpenMesh file ( *.om ) in CGALlab. This file format stores also edges and vertices marked as features. For the moment the function itself is not documented.

Release Management

  • License and copyright ownership: GeometryFactory
  • depends on PR #8332

afabri avatar Aug 22 '24 14:08 afabri

In the demo, loading a .om file containing a surface mesh that has no feature vertices and no feature edges should not create a selection item. This PR should be modified to have this behaviour

janetournois avatar Sep 09 '24 13:09 janetournois

Cannot open include file: 'CXGAL/IO/OM.h'

sloriot avatar Sep 17 '24 06:09 sloriot

Failed in 6.0-Ic-327 and must be tested again. Fix is committed.

afabri avatar Sep 20 '24 06:09 afabri 

/mnt/testsuite/test/Lab_Demo/Plugins/IO/OM_io_plugin.cpp:208:10: fatal error: om_io_plugin.moc: No such file or directory
  208 | #include "om_io_plugin.moc"

I guess you are missing something in the cmake list of the plugin

sloriot avatar Sep 25 '24 13:09 sloriot 

/mnt/testsuite/test/Lab_Demo/Plugins/IO/OM_io_plugin.cpp:208:10: fatal error: om_io_plugin.moc: No such file or directory
  208 | #include "om_io_plugin.moc"

in https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0.1-Ic-342/Lab_Demo/TestReport_lrineau_Debian-Testing.gz

sloriot avatar Oct 08 '24 08:10 sloriot

ICE on MSVC 2022. See here

sloriot avatar Oct 14 '24 13:10 sloriot

Actually there is also an ICE here so maybe it has nothing to do with this PR

sloriot avatar Oct 14 '24 13:10 sloriot

Successfully tested in CGAL-6.0.1-Ic-351

sloriot avatar Oct 18 '24 15:10 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Oct 23 '24 09:10 github-actions[bot]

/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-3/include/CGAL/IO/polygon_mesh_io.h:84: warning: unable to resolve reference to 'IOStreamOM' for \ref command

sloriot avatar Oct 24 '24 12:10 sloriot

Do we have to say that this needs OM installed as third party library? Because we have not written functions for writing ourselves.

afabri avatar Nov 08 '24 15:11 afabri

Indeed it needs OpenMesh and it should be documented

janetournois avatar Nov 08 '24 15:11 janetournois

it is already documented \note This function is only available if OpenMesh is available (CGAL_USE_OPENMESHis defined or CMake target is linked withCGAL::OpenMesh_support).

sloriot avatar Nov 08 '24 16:11 sloriot

Successfully tested in 6.1-Ic-18/19

sloriot avatar Nov 14 '24 06:11 sloriot