cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

Installation - update `FindOpenMesh.cmake`

Open janetournois opened this issue 1 year ago • 5 comments

Summary of Changes

This PR updates CGAL's FindOpenMesh.cmake, accordingly with the one provided by OpenMesh 11.0, and introducing the target OpenMesh::OpenMesh

Release Management

  • Affected package(s): Installation
  • License and copyright ownership: unchanged

janetournois avatar Jul 03 '24 12:07 janetournois

Since the target is from CGAL, shouldn't be prefixed with CGAL? Or even CGAL_OpenMesh_support to be consistent?

sloriot avatar Jul 04 '24 16:07 sloriot

Successfully tested in CGAL-6.0-Ic-300

sloriot avatar Aug 01 '24 16:08 sloriot

I have unpushed temporary code to add the CGAL prefix as you suggested @sloriot Do not merge this PR yet

janetournois avatar Aug 02 '24 07:08 janetournois

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Aug 27 '24 12:08 github-actions[bot]

Christo is up-to-date to test CGAL examples with OpenMesh-11.0

janetournois avatar Aug 27 '24 13:08 janetournois

Successfully tested in CGAL-6.0-Ic-321

sloriot avatar Sep 06 '24 11:09 sloriot