Sebastien Loriot

Results 671 comments of Sebastien Loriot

@efifogel do you see how to replace the hana based code?

``` /Users/magritte/cgal_root/CGAL-5.6-Ic-182/include/CGAL/draw_arrangement_2.h:126:72: warning: unused parameter 'approx' [-Wunused-parameter] auto bounding_box_impl2(CGAL::Bbox_2& bbox, const Point& p, T const& approx, ^ /Users/magritte/cgal_root/CGAL-5.6-Ic-182/include/CGAL/draw_arrangement_2.h:136:72: warning: unused parameter 'traits' [-Wunused-parameter] auto bounding_box_impl1(CGAL::Bbox_2& bbox, const Point& p, T...

Compilation and runtime errors [here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.6-Ic-182/Arrangement_on_surface_2_Examples/TestReport_Christo_MSVC2015-Release-64bits.gz) and [there](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-5.6-Ic-182/Arrangement_on_surface_2_Examples/TestReport_Christo_MSVC2017-Debug-64bits.gz)

Failing in [CGAL-5.6-Ic-186](https://cgal.geometryfactory.com/CGAL/testsuite/results-5.6-Ic-186.shtml)

Runtime errors in CGAL-5.6-Ic-236

Various tests failing in CGAL-5.6-Ic-196

It is not reasonable to have this branch in 5.6 since we don't have yet a green testsuite and no bench on memory and runtime. I postpone it to 5.7

Successfully tested in CGAL-5.6-Ic-247

Compilation issue on macOs, see [here](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-154/STL_Extension/TestReport_magritte_arm64-apple_bigsur_clang1200-release-64bits.gz) for example.