cgal icon indicating copy to clipboard operation
cgal copied to clipboard

PLY: Support writing per-face/vertex property lists

Open nh2 opened this issue 3 years ago • 7 comments

Summary of Changes

Hi, I'd like to contribute the writing of PLY property lists.

This allows to directly write multi-texture PLY files with CGAL that can be opened directly in e.g. MeshLab, as well as other use cases that require property list.

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

nh2 avatar May 12 '22 11:05 nh2

There should be a test .cpp file using the feature.

lrineau avatar May 13 '22 10:05 lrineau

@lrineau Could you point me at a similar test to get some inspiration from, and how it is added to the test suite? Thanks!

nh2 avatar May 13 '22 11:05 nh2

Hello @nh2, Each package has a subdirectory test. And this one has a subdirectory data. So it should go here.

afabri avatar May 13 '22 12:05 afabri

Successfully tested in CGAL-5.5-Ic-95

sloriot avatar May 31 '22 13:05 sloriot

Successfully tested in CGAL-5.6-Ic-22

sloriot avatar Jul 08 '22 18:07 sloriot

What is the status of this pull-request? As far as I can see, it seems waiting for tests. See https://github.com/CGAL/cgal/pull/6575#issuecomment-1125875273 and following message.

lrineau avatar Sep 13 '22 10:09 lrineau

Exactly, I did some refactoring after the initial patch but the main remaining point is testing the new feature added.

sloriot avatar Sep 13 '22 11:09 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Apr 12 '23 11:04 github-actions[bot]

Successfully tested in CGAL-5.6-Ic-247

sloriot avatar May 11 '23 06:05 sloriot