Sebastien Loriot
Sebastien Loriot
You can change the scope because that is the end goal of the internal change.
Thanks for the update Giles. There are a few things puzzling me that I'd like to check (mainly why the copy constructor does not need the new `bool` parameter to...
Successfully tested in CGAL-5.4-Ic-131 (still need to have a look at the new function)
After a quick look, here is how I think it works: - `shell_to_nef()` simply import the combinatorics i.e. sphere maps and co. without any volume notion (mark are set to...
Successfully tested in CGAL-5.4-Ic-115
Actually, I missed one column and there are some new warnings: ``` C:\CGAL_ROOT\CGAL-5.4-Ic-115\include\CGAL/Iso_cuboid_3.h(87): warning C4244: 'argument': conversion from 'double' to 'const float', possible loss of data [C:\CGAL_ROOT\CGAL-5.4-Ic-115\cmake\platforms\MSVC2015-Release-64bits\test\Intersections_3\bbox_other_do_intersect_test.vcxproj] C:\CGAL_ROOT\CGAL-5.4-Ic-115\include\CGAL/Point_3.h(80): warning C4244:...
@lrineau @afabri said he does not want to fix the new warnings introduced because it is an old compiler. So either we merge this PR that fix no warning detected...
You need to make sure that the header files included are the one from the libraries you compiled yourself. Otherwise you will get the binary incompatibility Laurent's talking about.
This issue is pretty old now. A new one should be created with the current warnings.
Successfully tested in CGAL-5.6-Ic-187