Sebastien Loriot

Results 671 comments of Sebastien Loriot

Isn't it this fixed by https://github.com/CGAL/cgal/pull/4795?

Do we still consider this issue as a release blocker or shall we postpone it ? (subtitles: @janetournois will you have time to work on it to find a solution...

The commit you are pointing changes the exact NT to basically be mpq instead of mpz. The reason for that is that some overloads (with triangles IIRC) are using a...

The testsuite looks good but only one platform has a recent enough version of boost. All windows are using boost 1.66 It does not make sense to make this PR...

Note that despite @janetournois updates, only 2 platforms are testing this PR (`Ubuntu-GCC_master_CXX20-Release` and `MSVC-2022-Preview-Release` CGAL-5.6-Ic-70). Boost 1.80 is required.

Successfully tested in CGAL-5.6-Ic-79 but we are missing a test on MacOS (monet being down)

Successfully tested in CGAL-5.6-Ic-84 on 9 platforms (GNU/Linux, MS Windows and macOS)

@fdrmrc https://github.com/CGAL/cgal/pull/6779 fixed the issue for me. Could you give it a try and let us know?

I think it would make sense to have a `append()` function in `Nef_polyhedron_3` class using your changes.