Chris Rizzitello
Chris Rizzitello
Please do see if you can integrate this into our ci jobs. We release on tags of `v*` and we have a `continuous` tag that is always the current code...
I have landed https://github.com/deskflow/deskflow/pull/8537 deskflow now has a `CONTRIBUTING.md` file
> Looks like the light logo (i.e. logo that should be used in light mode) is being displayed in your screenshot. I'll test on mine and see if I get...
> ```diff > - versionLayout->addSpacerItem(new QSpacerItem(50, 0, QSizePolicy::Fixed, QSizePolicy::Fixed)); > ``` So we want that version label tucked all the way to the left ? Fine with me > ```diff...
> ```diff > - lblLogo->setPixmap(icon.scaled(250, 500, Qt::KeepAspectRatio, Qt::SmoothTransformation)); > ``` This logo is a tad small so i bumped it up we can keep it at 100% size
> ```diff > - mainLayout->addWidget(label_importantDevs); > ``` >label QLabels that are a static label Style guide
> Ok, now it's working but maybe logo is a tad fuzzy? > > Hmm, also the copy button isn't showing for me. I'm on GNOME, not sure if relevant....
Please do not make reviews in the form of a large diffs. It makes the review much harder to follow.
> Changed include ordering for safety (to avoid accidental include resolution) What are you trying to avoid ? > Add spelling entry for "Devs" Why is this included i do...
> > Please do not make reviews in the form of a large diffs. It makes the review much harder to follow. > > Yes, I was wondering if it...