Siddharth Suresh
Siddharth Suresh
> I'm looking into the diagnostic events, and it looks like some of the diagnostics are missing only when trace logging is enabled. I believe the trace hook is interfering...
I need to update the docs as well
Closing this. The linked issue should be fixed by https://github.com/stellar/stellar-core/pull/4434.
I wonder if we should just remove the flag and always have prev enabled. @graydon Is there any benefit to removing the prev crate other than slightly reducing the binary...
Closed by https://github.com/stellar/stellar-core/pull/4434
Do you have a testcase that pushes a vnext valid parallel tx set in v22?
> > Do you have a testcase that pushes a vnext valid parallel tx set in v22? > > Parallel tx sets are not supported in v22, but if you...
> Will this work stay in a PR until a point closer to p25? Or is the hope to merge this and release it along with the env crates as...
> All my remaining comments are non-blocking. Good to merge this once timing is ready. I don't think we should merge this into `main`. That would prevent us from releasing...
> I wonder if this change is necessary vs using `dump-ledger` (with the changes that allow querying hot archive). There is a little bit of additional code required to build...