Siddharth Suresh

Results 40 comments of Siddharth Suresh

The checks now run in < 60 minutes, not 90 minutes.

### Conservation of Non-Native Assets We would like to add an invariant for non-native assets that mimics the `ConservationOfLumens` invariant. Ideally, we would be able to use the same logic...

1. That's a valid concern. When I thought about this problem initially, I believed that any rollback after balances have been changed would be due to a failed operation, so...

[This](https://github.com/stellar/rs-soroban-env/blob/992edd74862cc0899d8e1c1e4e7a7adc91a700b9/deny.toml#L95-L98) section can be removed after we upgrade the arkworks suite.

The restoreTx is missing [here](https://github.com/stellar/stellar-core/blob/fbc709780ee61cab338fd097c2597df2fad344ca/src/main/CommandLine.cpp#L1311-L1324), which is only hit if you don't use `--signtxs` with `get-settings-upgrade-txs`. This should be fixed as well.

I don't think we should do this, but is the ask here to attach contract id's to diagnostics that don't take place within a contract?

@MonsieurNicolas you mentioned using `--cpu-period=100000 --cpu-quota=40000` to limit resources as an example. If the docker image is being run on one of our dev machines (same hardware as our validators)...

To clarify, I was able to get the IOPS throttling working on the dev machine using the `--device-write-iops` and `--device-read-iops` docker options.

The protocol discussion [thread](https://github.com/orgs/stellar/discussions/1772) has a more up to date view on the scope. The host functions to add are mentioned [here](https://github.com/orgs/stellar/discussions/1772#discussioncomment-14489791).

I'm looking into the diagnostic events, and it looks like some of the diagnostics are missing only when trace logging is enabled. I believe the trace hook is interfering with...