stellar-core icon indicating copy to clipboard operation
stellar-core copied to clipboard

Have the flag enable-protocol-upgrade-via-soroban-env-host-prev set by default

Open anupsdf opened this issue 1 year ago • 2 comments

What:

Have the flag enable-protocol-upgrade-via-soroban-env-host-prev set by default. Introduce a new flag to exclude prev so it can be used for minor releases after the protocol upgrade.

Why:

Nodes without the prev host will reject protocol upgrades during consensus. During protocol 21 upgrade we saw a validator had built core from source and missed setting this flag. This caused them to loose sync during the upgrade.

anupsdf avatar Jun 18 '24 17:06 anupsdf

I wonder if we should just remove the flag and always have prev enabled. @graydon Is there any benefit to removing the prev crate other than slightly reducing the binary size?

sisuresh avatar Jun 18 '24 18:06 sisuresh

Nothing comes to mind, I'd certainly be willing to try it and see if anything goes wrong.

graydon avatar Jun 18 '24 22:06 graydon

Closed by https://github.com/stellar/stellar-core/pull/4434

sisuresh avatar Aug 28 '24 21:08 sisuresh