stellar-core icon indicating copy to clipboard operation
stellar-core copied to clipboard

The Next github checks are taking ~90 minutes.

Open sisuresh opened this issue 2 years ago • 3 comments

You can see here that both GCC Next and Clang next took around 90 minutes, while GCC current and Clang Current took around 15 minutes. This results in a much longer wait time to get a change merged into master, affecting how quickly we can release a build.

Some guesses as to where the issue could be -

  • Caching issue
  • rust bridge header could be included in a widely used header, resulting in full rebuilds

sisuresh avatar Feb 21 '23 20:02 sisuresh

This might not be a rust issue. This GCC current run took around 90 minutes - https://github.com/stellar/stellar-core/actions/runs/4126381089/jobs/7128229604.

sisuresh avatar Feb 22 '23 01:02 sisuresh

it is expected to see ~ full rebuilds (we expire caches). So the question is: are rust builds always slow?

MonsieurNicolas avatar Feb 24 '23 22:02 MonsieurNicolas

I'm currently seeing >1h for all builds, current and next. maybe we broke caching or no longer fit?

graydon avatar May 01 '23 20:05 graydon

The checks now run in < 60 minutes, not 90 minutes.

sisuresh avatar Jun 17 '24 21:06 sisuresh