Pieter Wuille
Pieter Wuille
A few high-level comments: * I don't think we should do link-time plugging in the same PR as runtime plugging, and when we do, I don't think it should be...
@furszy From a quick glance, the passing of the function everywhere is fine I think. I'd suggest passing a pointer to `secp256k1_hash_context` to the sha256 functions rather than the function...
> The output is nice for sure, but wouldn't it be much simpler to just invoke the test binaries with -j? I don't think that's desirable, because it lacks the...
Weak Concept NACK. Given how broken the examples are, I think we should fix them throughout and add testing to prevent regressions, or get rid of them entirely.
@roqqit That sounds like an unrelated issue, which may be specific to your fork. This issue is about the node not detecting that its database is corrupted, and thus incorrectly...
I agree, it's cleaner to just let the user provide proper entropy, leaving the responsibility outside of the library.