Pieter Wuille comments

Results 753 comments of


                                            Pieter Wuille

Memory zeroization improvements

Not without checking the binary, you mean; no, that's why @gmaxwell is saying that it is best effort.

ci, iwyu: Treat warnings as errors for specific targets

Concept ACK

cmake: add optional source files to bitcoin_crypto directly

Concept ACK. If it's possible to have differently-compiled compilation units without needing separate libraries for each, then this does seem like a cleaner solution. I suspect we perhaps ended up...

Add MuSig2 module

Concept ACK

doc: mention `descriptorprocesspsbt` in psbt.md

ACK ebb6cd82baf8406454b18afcb8ccb4e1dde0d43e

msan: notate more variable assignments from assembly code

utACK f7f0184ba1358cb8659607d2d0105628cb130e4f

Clear sensitive memory without getting optimized out (revival of #636)

utACK c9210784f7300ad8209094b98e865e96e9efe2e6. I have not reviewed this for exhaustiveness (as in, are there more places where clearing is useful/necessary), but the code changes look good.

Clear sensitive memory without getting optimized out (revival of #636)

reACK 765ef53335a3e0fafdafe1e757f6fe0789f2797f

Listen on random port by default (not 8333)

Concept ACK. Regarding DNS seeds, I think there is a 3rd option, which I favor. We keep the DNS seeds, but treat them always as addrfetch peers, rather than as...

p2p: improve TxOrphanage denial of service bounds

The changes here have surprisingly little effect on the included benchmarks: * [bench] TxOrphanage::LimitOrphans | ns/op | op/s | err% | total | benchmark |--------------------:|--------------------:|--------:|----------:|:---------- | 68,742,718.06 | 14.55 |...