Pieter Wuille
Pieter Wuille
@ismaelsadeeq Yeah, the benchmark is in my "all txgraph" branch which also includes #32263. Removing the `NUM_ACCEPTABLE_ITERS` variable should be fine.
Addressed nits, and also incorporated the benchmark in this PR.
I have simplified the eviction interface. Instead of getting a `TxGraph::Evictor` object through `TxGraph::GetEvictor()`, there is now a simpler `TxGraph::GetWorstMainChunk()` function, which is a pure inspector.
I modified `TxGraph::GetWorstMainChunk()` to return the chunk feerate in addition to the list of transaction Refs.
Rebased after merge of #31363, and on top of #32151.
Rebased on top of #32218 to fix CI issue.
Rebased after merge of #32218. Still includes #32191.
Changes made to address @monlovesmango's comments: ```diff --- a/src/txgraph.cpp +++ b/src/txgraph.cpp @@ -282,6 +282,27 @@ private: return a->m_sequence b->m_sequence; } + /** Compare two entries (which must both exist within...
> Interesting, I guess my interpretation is different and don't understand where the +1 comes from. I would have thought the number of choices is simply the tx count plus...