bips icon indicating copy to clipboard operation
bips copied to clipboard

bip-0324: fix git instruction order in test_sage_decoding.py

Open theStack opened this issue 2 years ago • 3 comments

Tiny fix correcting the order of commands, for git checkout one has to change into the repository directory first.

theStack avatar Jul 06 '23 14:07 theStack

(unrelated to this PR but related to BIP 324) - you could also remove https://github.com/bitcoin/bips/blob/master/bip-0324/xswiftec_test_vectors.csv maybe? xswiftec_test_vectors.csv isn't being used anywhere and I'd assume it's a leftover from the previous revision of the doc which replaced it with xswiftec_inv_test_vectors.csv(currently used).

stratospher avatar Jul 07 '23 07:07 stratospher

@real-or-random @jonasschnelli @sipa

luke-jr avatar Jul 09 '23 17:07 luke-jr

LGTM

sipa avatar Jul 09 '23 17:07 sipa