Sindre Sorhus
Sindre Sorhus
@tusbar I don't like how it would completely opt out of all the default ignores. You would have to define a lot of `ignores` boilerplate in many projects. I prefer...
> had a script called bundle.js Hmm, I'm leaning towards just removing `bundle.js` from default ignores. I've never used that naming myself and it feels too opinionated. The default ignores...
>> Hmm, I'm leaning towards just removing bundle.js from default ignores. > Agreed. Done: https://github.com/xojs/xo/commit/8e4f4355c4b8e62bc28f37e3673bb6872e693bb0 > fast-glob do not handle ignore globs together. So setting ignore to [!**/bundle.js, **/bundle.js] still...
Makes sense. Wanna try doing a pull request?
@kevva We could do it for all specified non-glob inputs. The only way to really detect whether something is a glob or a direct file reference is to `fs.existsSync()`.
I don't think it's a good idea to have this built-in. However, you could instead propose an option to the rule which could enable users to implement it themselves. Like...
Makes sense, but not sure it's worth the effort or churn. Maybe we should just collect it in a list and do multiple renames in a batch when we have...
> You need to make sure that what is sliced is actually an array There's no way to statically know that it's actually a `Blob`. We assume most cases are...
This is now accepted.
> Can this auto fix to this when it's the same? "globalThis" is so awkward. In what situations are they the same? > Also it should exclude window’s actual properties,...