Sindre Sorhus

Results 4177 comments of Sindre Sorhus

> Is this applicable to other classes as well? `window.location.href` and `window.location.toString()`

> Thought this is not equivalence, maybe RegExp#source over RegExp#toString()? That doesn't really make sense to me. They are used for different purposes. `.source` is used when you want to...

Let's go with `prefer-url-href`. It can be made more general later on if we discover more useful cases to catch.

> Related: https://github.com/sindresorhus/xo/blob/2d26d79ea81f893fc7b1ff9e586c1e74ad28c830/options-manager.js#L98 Hmm. We just set the default value there. It's later extended by your custom config.

> Why does xo forces these default rules here (https://github.com/sindresorhus/xo/blob/2d26d79ea81f893fc7b1ff9e586c1e74ad28c830/options-manager.js#L98) ? The Babel parser and plugin have some incompatible rules. So we first need to reset the original rules, then...

This should be fixed in https://github.com/sindresorhus/xo/commit/cece3dd2893efe0499380e6f8db654c18b6210e6, but with ESLint changes and this, it would be nice if you all could take a look at the changes. @vdemedes Can you try...