Sindre Sorhus comments

Results 4160 comments of


                                            Sindre Sorhus

Unable to customize certain rules via shareable config

I ended up reverting to the previous workaround. Don't have time to fix this properly right now. New version is out btw. I still would like to see this fixed...

Unable to customize certain rules via shareable config

@bfred-it I'm not sure what you're asking? Doesn't seem relevant to this thread.

Unable to customize certain rules via shareable config

@bfred-it I don't remember, but it ended up landing regardless: https://github.com/sindresorhus/xo#config-overrides

Rule proposal: `prefer-array-map`

I would wait on https://github.com/tc39/proposal-iterator-helpers

Expand `prefer-dom-node-text-content` against `.innerHTML` or implement `no-inner-html` rule

Maybe we could make a more general `no-unsafe-dom` rule. For example, with [Trusted Types](https://github.com/w3c/webappsec-trusted-types), `.innerHTML` is not dangerous. Alternatively, a `prefer-trusted-types` rule.

Support check `.unshift()` in `no-array-push-push`

Sounds good 👍

Rule proposal: Number(str) over parseFloat(str)

Accepted

Support adding text captions

This is most likely not happening. Gifski is intended to be a GIF converter. However, I'm leaving this open in case anyone wants to work on this. It's expected that...

Auto save at user provided default location

Can you describe your use-case? Why do you need a default location? I'm asking as how I use it I don't even need "Save As" at all, as I just...

A way to override the default ignores

I would have thought that would work, and it definitely should. XO comes with good defaults, but everything should be overridable when needed.