Sindre Sorhus

Results 4163 comments of Sindre Sorhus

@Richienb Maybe we could detect this case and add a human-friendly error message?

Would you be able to elaborate what other problem it causes? For posterity.

@Richienb Thanks for elaborating. It's seems we have hit a dead-end... Maybe it's worth opening an ESLint issue with a proposal with an option/API that could resolve this issue.

I feel like ESLint has way too many options and CLI flags and I don’t want to overload users with all that. I also see value in being able to...

@jamestalmage Probably https://github.com/sindresorhus/xo/blob/bfb1b4fed0e6b8d946c341bdc06f65d63265a0db/options-manager.js#L105-L116 Maybe we should ask ESLint to expose that method?

> Any steps forward with this? Opening an issue on ESLint asking them to expose the method for resolving `extends`, so we don't have to implement a "broken" version ourselves....

ESLint issue opened: https://github.com/eslint/eslint/issues/7328

The ESLint team says the underlying problem has been fixed in ESLint, so we should be able to rip out our custom resolve logic: https://github.com/xojs/xo/blob/510d02e3c4d26d07a7ba9bdcbd03f93987d596bb/lib/options-manager.js#L254-L282 We need to add a...

Not that I can think of right now. It's fine to have a targeted rule. It makes it easier to reliably detect the correct cases.