Simson L. Garfinkel
Simson L. Garfinkel
Nice going. The only failed test is the code coverage. However, I'm requesting a slight rephrasing of your internal documentation.
> @Taha-Ebrahim can be null, see [#3302 (comment)](https://github.com/sleuthkit/sleuthkit/issues/3302#issuecomment-2981072244) it is made null by > > ``` > img_parent = std::move(img); > ``` > > So maybe the ideal fix is:...
Neat. But what is correct behavior? Is it refusing to read the data, or recovering the data? If TSK refused to read, how would the data be read?
I don’t know of any way that we have a tagging the data, other than creating a fake directory entry and returning it in another stream. This is something that...
> > I don’t know of any way that we have a tagging the data, other than creating a fake directory entry and returning it in another stream. > >...
I think that this and other significant issues should be noted, but that we should not even consider addressing them for the next release. I have added a tag called...
I'm eager to accept this fix, but do you have a test image that demonstrates the error and then passes with this fix? Or is this just a correctness issue...
Thanks. @Taha-Ebrahim tested this and says it works. He has created a test image. We're going to bring it up shortly. Have you managed to fix @uckelman's code so that...
I don't know if he's likely to do it. However, the fact that it doesn't work represents a failure in our automated testing. So clearly we need to do test...