Simson L. Garfinkel
Simson L. Garfinkel
I asked @copilot to review this, but it would be great if @APriestman or @bcarrier could also give it a look.
Can you rebase this to the current develop branch so that the unit tests will run? Thanks.
we might as well merge this in now.
Okay, I've reviewed this, and it looks like this support is now present.
Waiting for comment from @igorrogov if this fixes noted problem.
We never got it, but it was reported by the OP that the patch worked. > On Nov 7, 2024, at 6:52 AM, Joel Uckelman ***@***.***> wrote: > > >...
I looked at the code in detailed. If it loops more than a million times, something is wrong. Take a look at the change. It isn’t big. > On Nov...
someone reported an infinite loop. I looked at the code and yes, a corrupt disk image would result in an infinite loop. We should never have infinite loops. So I...
> `LOGICAL_MAX_ATTR_RUN` can't be the correct loop limit. It's not related to the contents of fs_attr.cpp Do you think hat we are likely to see more than 0x7fffffff data runs?...
But I put the define there as part of the PR. It’s not an unrelated define. This is the only place in the source code where that define is referenced....