Simson L. Garfinkel comments

Results 853 comments of


                                            Simson L. Garfinkel

strncat in auto_db_java.cpp uses incorrect third argument for strncat

> My guess is that strncat was used because nearly every complier complains about any use of strcat and they say strncat is more safe. > > It looks like...

strncat in auto_db_java.cpp uses incorrect third argument for strncat

strncat's definition of "appends not more than n characters from s2, and then adds a terminating ‘\0’." is so broken. > On Mar 21, 2025, at 10:08 AM, Brian Carrier...

document location of from_brian or remake tests so that they can run without magic disk images

Some of them appear to be here: https://sourceforge.net/projects/dftt/files/Test%20Images/

tsk_UTF16toUTF8 OOB read

> [@simsong](https://github.com/simsong) what is the desired behavior here? The code deliberately tries to correct a NTFS index value that is incorrect and then carries on to use that to determine...

Test 4.13 release with autopsy

@jayaramcs - resurfacing this. Do we have an automated test that we can point to?

Image block cache improvement

Hi. I'm curious about the use of the C++ timers in here. Do you have thoughts on this, as to why they are being used, and what they are for?

Image block cache improvement

But they just give wall time, right? Wouldn't CPU performance registers or os time functions be more accurate?

XFS Implementation

Hi. We're really excited to take the XFS implementation. However: * We need this rebased against develop, as there are a lot of conflicts. * We really need an XFS...

XFS Implementation

How is this different from https://github.com/sleuthkit/sleuthkit/pull/1476?

tsk_loaddb 4.3 much slower than 4.2

@lfcnassif - I cannot access your NTFS disk image. If you still have it, please re-open this ticket so I can do performance testing.