Simon Schölly comments

Results 188 comments of


                                            Simon Schölly

[BUG] Error when running example code UndefVarError: libsgtsnepi not defined

I think we can close this for now.

WIP: Add an `is_chordal` algorithm

Do you by any change know where I could find a public accessible version of that paper? My usual methods did not help.

WIP: Add an `is_chordal` algorithm

> @simonschoelly, just wanted to let you know I certainly haven't abandoned this PR. I was busy with work this past week and I'm at a conference this weekend, but...

WIP: Add an `is_chordal` algorithm

There is also https://github.com/wangjie212/ChordalGraph

WIP: Add an `is_chordal` algorithm

You resolved that conversation but might have overlooked what I wrote there about using the `IsDirected` trait.

Use `iszero(?)` instead of `?==zero(...)` for warning when adding edge, for Symbolics Num compatibility

Would it make sense to add Symbolics to the tests and write a small unit test so that this will not be accidentally removed in future releases?

Use `iszero(?)` instead of `?==zero(...)` for warning when adding edge, for Symbolics Num compatibility

I am very unfamiliar with Symbolics otherwise I would have tested it myself but is this also a case we have to consider? https://github.com/JuliaGraphs/SimpleWeightedGraphs.jl/blob/8128430c9f1a5a2f2cd9dd2b89d72916c811b257/src/overrides.jl#L71

Typical graphs to test on?

I wanted to write some guidelines on benchmarking for a very long time but have not gotten around it. But let me write down some of my unstructured thoughts here:...

Please tag new release compatible with JLD2 0.5.

I think it would be helpful to add CompatHelper to this repo.

[automation issue] renable CompatHelper GH Action (disabled on inactivity)

Thanks I enabled it again. I am not sure why it was disabled, it said something about no activity for the last 60 days - but I am not sure...