Simon Schölly
Simon Schölly
There is this one comment from me, about `k >= 0` - not sure if you have seen it, but feel free to ignore that it you think we should...
This is an interesting operator, I added a few suggestions.
Having to many different constructors might indeed might indeed make things more confusing. So we could think about removing this constructor when releasing the next major version. On the other...
Thanks, this makes a lot of sense. And sorry for the long delay, I was busy with other kinds of things. Could you also quickly add a short paragraph to...
Finally merging this. Thanks!
A general dependency update is definitely something that is needed here - I wonder though, in your PR you remove the `[compat]` section - is that done on purpose?
Yes, (I think we did discussed that on slack before), we should get StructOfArrays into JuliaArrays and deprecate this package.
Adding self-loops to graphs it not very difficult from a technical perspective (unlike multi-edges), so while it does not strictly correspond to the mathematical definition of a simple graph, we...
If you look at some functions in LightGraphs, like `diameter` for example: https://github.com/JuliaGraphs/LightGraphs.jl/blob/77870d4702145e2a1cfe804d0f1ec481f2e94617/src/distance.jl#L106, then they always use the `weights` function, even if there are no weights for a graph. The...
> Also, for some reason the tests fail because `swg` is unknown, even though I define the constant in `runtests.jl` You need to load SimpleWeightedGraphs in your tests - either...